Skip to content

fix(release): generate valid Homebrew formula URLs#98

Merged
wauputr4 merged 1 commit into
mainfrom
fix/homebrew-formula-interpolation
Jun 15, 2026
Merged

fix(release): generate valid Homebrew formula URLs#98
wauputr4 merged 1 commit into
mainfrom
fix/homebrew-formula-interpolation

Conversation

@wauputr4

@wauputr4 wauputr4 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

  • fix Homebrew formula generation so Ruby #{version} interpolation is not escaped
  • document the release automation fix in the changelog

Validation

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Homebrew formula download URLs to correctly resolve version information for supported architectures.
  • Documentation

    • Updated changelog with release notes.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e03c15b4-639e-4596-806a-9186775e83bb

📥 Commits

Reviewing files that changed from the base of the PR and between 613292c and 8cc78cd.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • CHANGELOG.md

📝 Walkthrough

Walkthrough

The release workflow's "Sync Homebrew tap" step removes the backslash escaping of Ruby #{version} interpolation in the generated Homebrew formula download URLs for all four platform/architecture variants. A corresponding Fixed entry is added to CHANGELOG.md under Unreleased.

Changes

Homebrew Formula URL Fix

Layer / File(s) Summary
Release workflow URL fix and changelog entry
.github/workflows/release.yml, CHANGELOG.md
Removes the \ escape before #{version} in the four Homebrew formula asset download URLs (macOS arm64/amd64, Linux arm64/amd64); adds a Fixed changelog entry describing the correction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hop, hop, a backslash fled,
The formula now reads what Ruby said,
#{version} shines, no longer escaped,
The tap is synced, the bottles shaped.
All four URLs, correct at last — hooray! 🍺

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing Homebrew formula URL generation to preserve Ruby interpolation syntax.
Description check ✅ Passed The description covers the fix and changelog documentation but omits validation checklist items and provider/security sections from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/homebrew-formula-interpolation

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md to document a fix that ensures generated Homebrew formula URLs correctly interpolate #{version} during release tap sync. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wauputr4
wauputr4 merged commit e5b16a9 into main Jun 15, 2026
7 checks passed
@wauputr4
wauputr4 deleted the fix/homebrew-formula-interpolation branch June 15, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant