Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run actions outside container to fix Linux build failure #1902

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Feb 4, 2025

I found some time to get this working again. It’s slightly annoying to do because actions cannot be run in a container selectively, but this should do for now.

@chchwy
Copy link
Member

chchwy commented Feb 4, 2025

Thanks! I was tackling this issue as well recently and apparently your solution is better than mine.

@chchwy chchwy self-requested a review February 4, 2025 12:46
@MrStevns
Copy link
Member

MrStevns commented Feb 4, 2025

Well done! I tried tackling this problem as well some time ago but failed.

@chchwy chchwy merged commit 5682937 into pencil2d:master Feb 5, 2025
8 checks passed
@chchwy
Copy link
Member

chchwy commented Feb 6, 2025

@J5lx I cherry-picked your fix to the release/7.0.1 branch, but it didn't work. I looked at the error message and don't quite get it. Would you be able to have a look?
https://github.com/pencil2d/pencil/actions/runs/13152084217

@J5lx
Copy link
Member Author

J5lx commented Feb 6, 2025

I already pushed a fix for that

@chchwy
Copy link
Member

chchwy commented Feb 6, 2025

I already pushed a fix for that

Oh, thank you for that! it's weird that the action didn't start on the release branch.

@J5lx
Copy link
Member Author

J5lx commented Feb 6, 2025

CI won’t run if only .sh files are modified. We’ve had it set up like that since when we were still using Travis I’m pretty sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants