Add support for Logo -> Generated Avatar preset - #444
Merged
Merged
Conversation
rr74w9zwdm-svg
changed the title
Added the missing 'only' in Arabic. Signed-off-by: rr74w9zwdm-svg <rr74w9zwdm@privaterelay.appleid.com>
The Chinese catalog used 'settingsPanel.avatarSource.bimi' instead of 'settingsPanel.avatarSource.bimiOnly', so check-locales flagged the string as missing/extra and the frontend check failed. Signed-off-by: Arne <arne@gmrze.net>
The new "bimi" case in SenderPhotos returned a.orderedPhotos(email, "bimi") on its own, one value short of the (photos, error) the function signature promises, so the package failed to build. Signed-off-by: Arne <arne@gmrze.net>
Member
|
Great work, and I really appreciated the note about the Chinese translation, that's exactly the kind of care we want here. Found two small things blocking CI (a zh-CN key mismatch and a missing error return in SenderPhotos), fixed both and pushed to your branch. Ready to merge on my end! |
Contributor
Author
|
Oh wow, never knew the errors were there! Thanks for letting me know, really appreciate guiding me through the issue. I am happy to do more contributions on the repo. Have a nice day! |
Contributor
Author
|
I am currently working on the Italian language support. Since its almost 2 months old, has it been claimed by someone yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442
Changed files in the
lib/localesdirectorry to addbimiOnlyoption in various languages.Added 'bimi' option in
SettingsPanel.svelte.Added new case for 'bimi' in
bind_avatar.go.Modifed comments to include 'bimi' in both
bind_settings.goandtypes.ts.A note:
For the Chinese version, I have researched to find this as the valid way to write it '仅Logo'. This way is to align with the other 'logo' written in original form and the letter '仅' means 'only'.
This could be a temporary solution till the rest is translated to Chinese.