Skip to content

Conversation

@notAreYouScared
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

Added a new goToStep(t) method to the wizard component that enables direct navigation to specific steps, with validation to check if the target step is valid and accessible, followed by updating the current step, autofocus, and scroll behavior.

Changes

Cohort / File(s) Summary
Wizard Navigation
public/js/filament/schemas/components/wizard.js
Added goToStep(t) method for direct step navigation with target validation, current step updates, autofocus, and scroll positioning.
🚥 Pre-merge checks | ❌ 3
❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'composer update' does not describe the actual changes made to the codebase. The PR adds a new goToStep() method to the wizard component JavaScript, not a composer dependency update. Update the title to accurately reflect the changes, such as 'Add goToStep() method to wizard component' or 'Implement direct step navigation in wizard component'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a meaningful description explaining the purpose and implementation of the new goToStep() method and why this change was necessary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@public/js/filament/schemas/components/wizard.js`:
- Line 1: goToStep currently relies on getStepIndex but because getStepIndex
coerces unknown steps to 0 an invalid step can be assigned to this.step causing
autofocusFields() to throw; update goToStep to first validate the incoming step
exists in getSteps() (e.g. check getSteps().includes(t) or that
getSteps().findIndex(...) !== -1) and only assign this.step and call
autofocusFields()/scroll() when the step is valid, leaving getStepIndex
unchanged.

Copy link
Member

@Boy132 Boy132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update gboquizosanchez/filament-log-viewer to 2.2

@notAreYouScared notAreYouScared merged commit 36de4c3 into main Feb 1, 2026
32 checks passed
@notAreYouScared notAreYouScared deleted the charles/composer-upgrade branch February 1, 2026 00:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants