Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve unit number sorting for fallback.housenumber queries #139

Merged
merged 1 commit into from
Jan 22, 2025
Merged

improve unit number sorting for fallback.housenumber queries #139

merged 1 commit into from
Jan 22, 2025

Conversation

missinglink
Copy link
Member

as described in pelias/api#1683

@missinglink missinglink mentioned this pull request Jan 21, 2025
Merged
@orangejulius orangejulius mentioned this pull request Jan 21, 2025
Merged
@orangejulius
Copy link
Member

Looks like good improvements based on pelias/acceptance-tests#568

ianthetechie
ianthetechie approved these changes Jan 22, 2025
View reviewed changes
Copy link

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this improves all of the queries that I was working on fixing without the complications of the analyzer approach I tried.

@missinglink missinglink merged commit 355b705 into master Jan 22, 2025
5 checks passed
@missinglink missinglink deleted the search-address-fallback-sorting branch January 22, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie approved these changes

@orangejulius orangejulius orangejulius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@missinglink @orangejulius @ianthetechie