refactor(kernels): the Marlin face serves both consumers from one module - #1020
Merged
FeathBow merged 1 commit intoAug 31, 2026
Merged
Conversation
Signed-off-by: Feathbow <feathbow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1019
The gemma4 and Kimi Marlin wrappers each carried the same buffer-to-pointer plumbing for the grouped GEMM and the align launch. A shared
ops/marlin_face.rsnow owns that face, generic over the scale type (u8for the NVFP4 face,Halffor WNA16 — an alias of the same width, so the shared pointers feed both FFIs unchanged); the launch functions consume their buffer structs by destructuring and hand each consumer a pointer set for its own FFI call. The FFI entry points, argument arithmetic and stream selection stay with their consumers, and no exported symbol changes name or signature.Test Env
Single GPU (
sm_89, 48 GiB, x86_64), the kimi-k2 leg compiles with ansm_90target override, which the moe chain's DeepEP shim requires.Verification
cargo fmt --all -- --checkandgit diff --checkpass.cargo clippy --release --features gemma4 -p pegainfer-kernels --all-targets -- -D warningspasses at the exact head.PEGAINFER_CUDA_SM=90 cargo check --release --features kimi-k2 -p pegainfer-kernelspasses at the exact head, 0 errors.pub fnsignature, noexterndeclaration and no entry-point string; consumers outside the two wrapper files compile without edits.