-
Notifications
You must be signed in to change notification settings - Fork 103
perf(gemma4): regular decode steps stop rebuilding what did not change #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FeathBow
merged 14 commits into
pegainfer-project:main
from
FeathBow:perf/gemma4-decode-overhead
Aug 30, 2026
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4c49ea0
perf(sample): the token read spins ahead of the parking wait
FeathBow 297c550
perf(gemma4): decode rounds pipeline the greedy sample turnaround
FeathBow a17fca9
perf(gemma4): regular decode steps upload nothing
FeathBow 7772c38
perf(gemma4): the staged sampler chain rides two graph launches
FeathBow 1c2269e
fix(kernels): the metadata advance takes its tables mutably and check…
FeathBow 49976d5
fix(kernels): the staged sampler path stays on the base stream
FeathBow 773846c
fix(gemma4): the pipeline fences the device before it drops a failed …
FeathBow 872c5d7
fix(kernels): the metadata advance bounds its index arithmetic to i32
FeathBow 5b08b46
fix(gemma4): the admission queue drains the pipeline only when it can…
FeathBow ca46460
docs(gemma4): the decode pipeline contract
FeathBow 286351f
test(gemma4): the full roster keeps its pipeline under a queue
FeathBow e5838c0
test(gemma4): the roster gate retires one incumbent before the other
FeathBow 0174422
fix(gemma4): the admission drains the pipeline only when it changes t…
FeathBow 7dbc296
fix(gemma4): a solo admission drops the retired roster's fingerprint
FeathBow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section asserts that the new pipelined sampler and device-side metadata advancement preserve token IDs, finish reasons, and counts, but the commit adds neither a production E2E/model evaluation for those output invariants nor same-context before/after performance results. Because the new path is exercised only for eligible greedy batches and crosses roster, page/chunk, cancellation, EOS, and length transitions, provide production coverage of those cases plus an A/B benchmark before treating the optimization as verified.
AGENTS.md reference: AGENTS.md:L110-L112
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure