feat: popover가 뷰포트 밖으로 나가면 반대 방향으로 이동한다 #823
Conversation
|
@Jongminfire is attempting to deploy a commit to the Class101 Team on Vercel. To accomplish this, @Jongminfire needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
…/popover-handle-position
| if ( | ||
| positionValue.includes('top') && | ||
| popoverY < 0 && | ||
| childY + childHeight + computedOffset + popoverHeight < windowHeight |
There was a problem hiding this comment.
요런 식들 공통의 함수로 묶어서 사용하긴 좀 어려울라나요 .. 👀
There was a problem hiding this comment.
최대한 공통 함수로 묶는 것 도전해볼게요 ㅋㅋㅋ
| popoverY < 0 && | ||
| childY + childHeight + computedOffset + popoverHeight < windowHeight | ||
| ) { | ||
| setPositionValue(positionValue.replace('top', 'bottom') as Position); |
There was a problem hiding this comment.
그런데 position 위치를 다시 셋팅하면 뚝딱거리지는 않나요??
There was a problem hiding this comment.
Popover에 애니메이션을 걸어놔서 첨부한 영상처럼 되긴 합니다~
There was a problem hiding this comment.
아 근데 영상은 resize 이벤트 달아놨을 때 기준이긴 해요
|
@neroli-101 is attempting to deploy a commit to the Class101 Team on Vercel. To accomplish this, @neroli-101 needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
…/popover-handle-position
2023-07-25.1.27.19.mov
2023-07-25.1.27.51.mov