android: Fix IntentFilter to not match all URLs #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intent filters can match on the data of an intent through the <data> tag. When multiple tags are present, they act as a boolean OR, intended if you want to match multiple data types. When a boolean AND is required, the attributes should instead be added to a single <data> tag. Two of our intent filters try to match ".pbw" and ".pbz" files. These both start with a single match on the "content" schema, followed by a match on the "*/*" MIME type, and finally a path filter for the file type in question. By virtue of being boolean OR, this meant that both filters would match every possible URL. Combine the attributes in a single data tag to turn it into a boolean AND for both of these filters.
hellcp
reviewed
Feb 28, 2025
| @@ -101,9 +101,7 @@ | |||
| <category android:name="android.intent.category.DEFAULT" /> | |||
| <category android:name="android.intent.category.BROWSABLE" /> | |||
|
|
|||
| <data android:scheme="content" /> | |||
| <data android:mimeType="*/*" /> | |||
There was a problem hiding this comment.
I don't know about pbz, but pbw is a zip archive, so you can use that mime type for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent filters can match on the data of an intent through the tag. When multiple tags are present, they act as a boolean OR, intended if you want to match multiple data types. When a boolean AND is required, the attributes should instead be added to a single tag.
Two of our intent filters try to match ".pbw" and ".pbz" files. These both start with a single match on the "content" schema, followed by a match on the "/" MIME type, and finally a path filter for the file type in question. By virtue of being boolean OR, this meant that both filters would match every possible URL.
Combine the attributes in a single data tag to turn it into a boolean AND for both of these filters.