Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest 27 #1

Closed
wants to merge 6 commits into from
Closed

Jest 27 #1

wants to merge 6 commits into from

Conversation

NathanPB
Copy link

I updated this to work with the current latest major version of jest =) Seems to be working fine

Copy link
Owner

@pckhoi pckhoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for the pull request. However, I see this error when I try to test. Are you seeing this?


 FAIL  test/setup_teardown.bench.ts
  ● Test suite failed to run

      ● Test suite failed to run

        TypeError: Cannot read property 'bind' of undefined

      at jestAdapter (node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:30:56)

It seems there is something breaking alright. Can you please take care of this?

package.json Outdated Show resolved Hide resolved
test/error.bench.ts Outdated Show resolved Hide resolved
test/basic.bench.ts Outdated Show resolved Hide resolved
test/setup_teardown.bench.ts Outdated Show resolved Hide resolved
@NathanPB
Copy link
Author

NathanPB commented Nov 1, 2021

Ima check that all in a few days, for my experience it looks like jest-circus is kinda broken, couldn't find a solution yet

@NathanPB
Copy link
Author

NathanPB commented Nov 2, 2021

The requested changes are done, just had to revert one commit. Jest-circus still broken tho

@pckhoi
Copy link
Owner

pckhoi commented Nov 4, 2021

Looks like the issue is that jest-electron still stucks at jest@v24: hustcc/jest-electron#32

Let's see how that goes.

@NathanPB
Copy link
Author

NathanPB commented Nov 4, 2021

Ye, but this issue is more than a year old, I don't think it's gonna happen anytime soon... I think we will be stuck with jest 24 forever

For the time being I published my fork on npmjs because I needed this library for my personal use. It's on @nathanpb/jest-bench (if anyone reading this in the future need it)

@pckhoi
Copy link
Owner

pckhoi commented Nov 14, 2021

I have publish [email protected] for those who want to use jest version 27. From now on jest-bench will take its version after jest's. Anyone who is still stuck at jest@26 can install [email protected].

@pckhoi pckhoi closed this Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants