-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/consolidate demo activities #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
grablack
wants to merge
52
commits into
develop
Choose a base branch
from
feature/consolidate-demo-activities
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly implement HTTP request for publishing artifacts to Central Portal API - Add detailed deployment status checking with proper API call - Display sync delay note to explain time gap before artifacts appear on Maven Central 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…blishing - Add multiple possible POM file locations including CI-specific paths - Add automatic POM file generation with proper XML tags - Implement more robust signature file handling with fallbacks - Add detailed logging for better debugging - Fix error handling with more informative messages 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace custom HTTP implementation with official Maven Central plugin - Add Maven settings and POM configuration - Fix authentication by using proper Maven settings - Update GitHub workflows to use the new publishing method - Add improved error handling and logging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix version expression in POM (changed from variable to hardcoded value) - Fix unknown packaging type 'aar' (changed to 'jar') - Fix artifact copying to extract classes.jar from AAR - Fix autoPublish variable substitution 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix YAML formatting issues that caused parsing errors in action.yml - Fix XML element name tags (<n> to <name>) - Add sed commands to replace variables properly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add maven-gpg-plugin to POM to sign artifacts - Add GPG profile to Maven settings.xml - Import GPG key before deployment - Pass GPG passphrase to Maven 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove the status check that was causing errors (not needed) - Add clear informational messages about the deployment status - Explain next steps after successful deployment 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Use the proper artifactId 'paypal-messages' instead of 'library' - Extract artifactId value dynamically from library's build.gradle - Update JAR filename to match correct artifactId - Add helpful information about the published artifact 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Dynamically extract the project name from build.gradle - Use project.ext.pom_name value (PayPal Messages) as the display name - Update deployment information output to show the project name - Fix all XML name tags to ensure proper format in POM file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Check for USE_SNAPSHOT environment variable in the GitHub Action - Add -SNAPSHOT suffix to version when USE_SNAPSHOT=true - This ensures snapshot releases use distinct versions from regular releases - Fix name tags in XML POM template for proper Maven Central standards 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Change project name to 'Messages' in the POM file - This will make the deployment show as 'Messages' instead of 'Deployment' in the Portal UI - Set the name directly rather than extracting it from the build file - Fix all XML name tags to ensure proper format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add new "Manual Publishing Approval" section with step-by-step instructions - Include information about clicking the Publish button in Sonatype Central Portal - Add link to the deployments page: https://central.sonatype.com/publishing/deployments - Add common issues section with explanations for "Component already exists" errors - Improve overall documentation structure and readability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…n release workflow
…te release-test workflow
… Portal publishing - Switch from incorrect direct API calls to NMCP plugin aggregation approach - Use proper Maven Central Portal API through community-supported plugin - Configure NMCP aggregation at root level with automatic publishing - This should resolve the 404 API errors and duplicate artifact issues
- Replace sed command that introduced tabs with awk approach using spaces - Ensures proper YAML indentation for GitHub Actions compatibility
- Change ${version} to + version to avoid YAML template variable conflict - This prevents the YAML parser from trying to interpret it as a GitHub Actions variable
… publishing to Maven Central
…sed components during snapshot publishing and configure signing for all tasks. Clean project before building to ensure fresh state.
- Force AAR packaging type in POM configuration - Add dependencies section to POM via withXml - Configure explicit publishing for library module - Fix artifactId and packaging in library/pom.xml These changes fix the build failures in consumer projects by ensuring the SDK is published with correct Maven metadata. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…y generated by Gradle
…strumentation tests in release-test.yml
…dle for minification - Introduced a new PROGUARD.md file detailing ProGuard rules for the PayPal Messages Android SDK, including rules for OkHttp, Gson, and Kotlin Coroutines. - Updated demo/build.gradle to include a debug build variant with minification enabled for testing. - Enhanced demo/proguard-rules.pro with necessary rules for OkHttp and Gson to ensure proper functionality during minification.
Code Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing instructions