-
Notifications
You must be signed in to change notification settings - Fork 123
feat: add jsdoc comments to v6 public interface types #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
8477c22
f6d881f
0dc4557
d651e6c
1599832
75252ac
6b7dcc8
b9f0713
87cea48
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@paypal/paypal-js": patch | ||
| --- | ||
|
|
||
| feat: add jsdoc comments to v6 public interface types |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,6 +7,26 @@ import { | |||||
| } from "./components/find-eligible-methods"; | ||||||
|
|
||||||
| export interface PayPalV6Namespace { | ||||||
| /** | ||||||
| * Creates an SDK instance with the specified components and configuration. | ||||||
| * | ||||||
| * This is an asynchronous method that initializes the PayPal SDK with the provided | ||||||
| * client token and components. The SDK is designed to be lightweight and modular, | ||||||
|
||||||
| * client token and components. The SDK is designed to be lightweight and modular, | |
| * client token and components. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's any context about what T is here for the generic to make sense. I wonder if we can replace with
| * @returns {Promise<SdkInstance<T>>} - A promise that resolves to an SDK instance with methods based on the specified components | |
| * @returns {Promise<SdkInstance<Components[]>>} - A promise that resolves to an SDK instance with methods based on the specified components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.