Skip to content

Remove isPayPalDomain from subscriptions props #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2025
Merged

Remove isPayPalDomain from subscriptions props #2568

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45809a3
remove isPayPalDomain from subscriptions props
wooslim Sep 25, 2025
4d7ff7c
Merge branch 'main' into feature/fss-remove-internal
wooslim Oct 1, 2025
1a1f196
remove unused import
wooslim Oct 1, 2025
6bbac7f
Merge branch 'feature/fss-remove-internal' of https://github.com/woos…
wooslim Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 25 additions & 29 deletions src/zoid/card-fields/component.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
getUserIDToken,
getSDKToken,
getClientMetadataID,
isPayPalDomain,

Check failure on line 28 in src/zoid/card-fields/component.jsx

View workflow job for this annotation

GitHub Actions / main 

'isPayPalDomain' is defined but never used
} from "@paypal/sdk-client/src";
import { getRefinedFundingEligibility } from "@paypal/funding-components/src";
import {
Expand Down Expand Up @@ -249,23 +249,21 @@
value: ({ props }) => props.parent.props.createOrder,
},

...(isPayPalDomain() && {
createSubscription: {
type: "function",
required: false,
value: ({ props }) => {
if (
props.parent.props.createSubscription &&
!props.parent.props.sdkToken
) {
throw new ValidationError(
`SDK Token must be passed in for createSubscription`
);
}
return props.parent.props.createSubscription;
},
createSubscription: {
type: "function",
required: false,
value: ({ props }) => {
if (
props.parent.props.createSubscription &&
!props.parent.props.sdkToken
) {
throw new ValidationError(
`SDK Token must be passed in for createSubscription`
);
}
return props.parent.props.createSubscription;
},
}),
},

createVaultSetupToken: {
type: "function",
Expand Down Expand Up @@ -601,20 +599,18 @@
required: false,
},

...(isPayPalDomain() && {
createSubscription: {
type: "function",
required: false,
value: ({ props }) => {
if (props.createSubscription && !props.sdkToken) {
throw new ValidationError(
`SDK Token must be passed in for createSubscription`
);
}
return props.createSubscription;
},
createSubscription: {
type: "function",
required: false,
value: ({ props }) => {
if (props.createSubscription && !props.sdkToken) {
throw new ValidationError(
`SDK Token must be passed in for createSubscription`
);
}
return props.createSubscription;
},
}),
},

createVaultSetupToken: {
type: "function",
Expand Down
Loading