Feature/update disable max height rebrand #2564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Jira Ticket:
https://paypal.atlassian.net/browse/DTPPCPSDK-2987
Type of change
Testing Plan
Below is information that validates the successful implementation of this feature and how a release manager can validate the success of a release candidate in the absence of the PR author.
PR Author:
@delbarrow
Backup Validator:
@nikrom17
PR Author's Team:
PPCP Web SDK
Test Environment URL:
Step-by-Step Validation
Step one: Navigate to the storybook and set the environment to the correct one (sandbox/msmaster)
https://github.paypal.com/pages/Core-SDK/paypalsdktestingnodeweb/?path=/story/button-rebrand-disablemaxheight--enabled
Step two: Make sure logo looks centered in button. The button container should be 200x150 and the label container should be 57px in height.
Step three: Navigate to the disableMaxHeight sizes story and confirm all buttons look normal.
https://github.paypal.com/pages/Core-SDK/paypalsdktestingnodeweb/?path=/story/testing-comparison-buttons--disable-max-height-sizes
Before/After Screenshots
Before:
After:
E2E Test Recording
DataDog Graph to Monitor
CAL Logs & Regex
Rollback Considerations
No
Are there any services dependent on this change?