fix: ensure unique IDs for new array rows in bulk updates #13783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR addresses a bug where bulk updating documents that include array fields with newly added rows would fail. Specifically:
store_statusesin the Users collection) across multiple documents in a single bulk update operation:Why?
The root cause was that Payload's bulk update operation reused the same temporary client-generated ID for new array rows across all documents being updated.
How?
The fix is implemented within the
updateOperationfor collections:updateDocument, a deep copy of the data is made.idproperty removed.Link to reproduction
https://github.com/JesperWe/bulk-update-array.git
Fixes #13736
Watch this