feat: improved lexical richText diffing in version view #11760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… converter is passed through
jmikrut
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Quick notes for future additions / enhancements:
- For blocks, we should try and output the
labels.singularrather than theslugfor human-friendly readability. - It would be nice if the
relationshipcomponent had arelationshipicon, so it looks similar to the upload node. - We should think through how users can define their own diffing components
- We already allow users to define their own
Diffcomponent for fields - could we also expose this same tactic on ablockconfig? Probably not.. because theDiffcomponent is for JSX (a React component). We need HTML. So maybe we could extend theblockconfig like we did forblock.jsx, i.e.block.html?
jmikrut
approved these changes
Apr 2, 2025
|
🚀 This is included in version v3.33.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our JSON-based richtext diffing with HTML-based richtext diffing for lexical. It uses this HTML diff library that I then modified to handle diffing more complex elements like links, uploads and relationships.
This makes it way easier to spot changes, replacing the lengthy Lexical JSON with a clean visual diff that shows exactly what's different.
Before
After