FISH-8649 Remove Clusters #7935
Draft
+3,063
−27,519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build completes, all unit tests pass, and the server starts. The admin console needs some further work though, as that currently encounters errors when attempting to load. Some of the JMS and IIOP changes raise concerns and will require testing as these seem extremely coupled together with Clusters, for example all of the master broker stuff: some stuff has outright been removed. We may need to do a pass with adding support for deployment groups through here, as there were some eyebrow raising ommisions with support for it in some places but not others. I also did some minor code cleanup as I made my way through, typically restricting myself to only doing so on the methods I was already editing, and removing missing package imports. The exception to this is with some of the JMS classes, as the formatting here was atrocious and making it difficult to read. Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
This command should now work for deployment groups, and no longer get a NPE when targetted at them
…ht, and clear up additional references
Adjusts the IiopFolbGmsClient implementation to use deployment groups instead.
This method didn't understand what to do if the value wasn't a property
Signed-off-by: Andrew Pielage <[email protected]>
…tIIOPEndpoints behaviour Always recalculate, and don't directly edit the currentMembers map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clusters have been deprecated since Payara 5: time for us to finally remove them.
Also removes some lingering GMS traces which missed getting removed in Payara 5.
WIP: Still need to finish reviewing the asadmin and admin console help pages. Also need to finish testing everything.
Includes a couple of additional related fixes:
get --monitor --aggregatedataonlyencountering errors when used on a deployment group rather than a clustercollect-log-filesworks against deployment groupsThese last two fixes may change behaviour - need to review/test
Also includes a bit of formatting here-and-there for some of the most egregiously badly formatted classes (looking at you JMS). I otherwise tried to constrain any formatting changes to the methods I was editing.
Important Info
Blockers
None
Testing
New tests
Reworked the Cluster quicklook tests as Deployment Group tests.
Testing Performed
Ran quicklook
Loaded the admin console and poked around (including in the "offline" help docs).
Testing Environment
Windows 11, Maven 3.9.12, Zulu JDK 21.0.10
Quicklook tests ran in WSL OpenSUSE Tumbleweed as the tests don't run on Windows
Documentation
Pending...
Notes for Reviewers
Good Luck™