Fix Issue 7197: Invalid No X509Certificate found WARNING spam from CertificateRealm #7913
+322
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalinchan
added
the
PR: Awaiting CLA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in
CertificateRealm.getCertificateFromSubject()where the method was incorrectly matching certificates against theIssuerX500Principalinstead of theSubjectX500Principal.According to the method name and its purpose, it should match against the certificate's subject (the entity the certificate is issued to), not the issuer (the CA that signed the certificate).
Important Info
Blockers
N/A
Testing
New tests
Created new test
nucleus/security/core/src/test/java/com/sun/enterprise/security/auth/realm/certificate/CertificateRealmTest.javaTesting Performed
Ran
mvn test -Dtest=CertificateRealmTest -pl nucleus/security/coresuccessfullyVerified the fix correctly identifies certificates by their subject rather than issuer
Testing Environment
Ubuntu 22.04, Maven 3.6.3, JDK 21.0.7
Documentation
Closes #7197
Notes for Reviewers
N/A