Fixing memory leak of com.sun.jts.CosTransactions.LogFileHandle #7901
+324
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to allow LogFileHandles to be GC'd correctly
Contributor
Author
|
Has successfully been tested : #7849 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #7849
Description
Fixing memory leak by moving cleanable state into static inner class instance and registering this with the Cleaner. Functionality operating on the state had to move into the state class to avoid referencig the LogFileHandle instance and thus preventing GC.
Important Info
Blockers
none
Testing
Needs to be done by someone able to reproduce the memory leak.
Testing Performed
PR pipeline
Notes for Reviewers
please see description