Skip to content

Conversation

@Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented Jan 16, 2026

Description

Replaces explicitly specifying the parent module version on every single POM, instead utilising the special revision variable (see https://maven.apache.org/guides/mini/guide-maven-ci-friendly.html).

Using other property names will cause warnings to be thrown (even though functionally it's essentially the same thing) e.g.

C:\Users\pandr\Git\Payara [Simplify-Project-Versioning]> mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\Maven"
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for fish.payara.server:payara-nucleus-parent:pom:7.2026.2-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ fish.payara.server:payara-aggregator:${payara.project.version}, C:\Users\pandr\Git\Payara\pom.xml, line 49, column 14
[WARNING]
[WARNING] Some problems were encountered while building the effective model for fish.payara.server:payara-aggregator:pom:7.2026.2-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ fish.payara.server:payara-aggregator:${payara.project.version}, C:\Users\pandr\Git\Payara\pom.xml, line 49, column 14
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:

Important Info

Blockers

None?
Related PR for release job: https://github.com/payara/EngineeringJenkinsjobs/pull/406
Related PR for EE7 Samples: payara/patched-src-javaee7-samples#110

Testing

New tests

None

Testing Performed

Created a temp clean maven repository and built the server: mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\Maven"

Did a mock "release" version change and did a build: mvn versions:set-property -DnewVersion=7.2026.2 -DgenerateBackupPoms=false -Dproperty=revision -pl . && mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\Maven

Followed by a "next snapshot" version change: mvn versions:set-property -DnewVersion=7.2026.3-SNAPSHOT -DgenerateBackupPoms=false -Dproperty=revision -pl . && mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\Maven

Testing Environment

Windows 11, Maven 3.9.12, Zulu JDK 21.0.9

Documentation

N/A?

Notes for Reviewers

Just look at the top-level pom - all other changes are just the property replacement.

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@kalinchan
Copy link
Member

Seems that the relativepath is wrong in appserver/tests/functional/payara-micro/pom.xml

Should be <relativePath>../../payara-samples/samples</relativePath>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants