Replace Per-Module Version with Single Property #7884
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces explicitly specifying the parent module version on every single POM, instead utilising the special
revisionvariable (see https://maven.apache.org/guides/mini/guide-maven-ci-friendly.html).Using other property names will cause warnings to be thrown (even though functionally it's essentially the same thing) e.g.
Important Info
Blockers
None?
Related PR for release job: https://github.com/payara/EngineeringJenkinsjobs/pull/406
Related PR for EE7 Samples: payara/patched-src-javaee7-samples#110
Testing
New tests
None
Testing Performed
Created a temp clean maven repository and built the server:
mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\Maven"Did a mock "release" version change and did a build:
mvn versions:set-property -DnewVersion=7.2026.2 -DgenerateBackupPoms=false -Dproperty=revision -pl . && mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\MavenFollowed by a "next snapshot" version change:
mvn versions:set-property -DnewVersion=7.2026.3-SNAPSHOT -DgenerateBackupPoms=false -Dproperty=revision -pl . && mvn clean install "-Dmaven.test.skip" -PBuildEmbedded -Pjakarta-staging "-Dmaven.repo.local=C:\Users\pandr\Downloads\MavenTesting Environment
Windows 11, Maven 3.9.12, Zulu JDK 21.0.9
Documentation
N/A?
Notes for Reviewers
Just look at the top-level pom - all other changes are just the property replacement.