Skip to content

React 19 ground work for heimdall #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gauravwarale
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 15, 2025 15:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR lays the groundwork for migrating to React 19 by updating all component return type definitions from JSX.Element to React.JSX.Element.

  • Updated return type annotations for components in Jobs, Commands, and Clusters modules
  • Standardized return types across multiple UI components to ensure consistency

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/src/modules/Jobs/Jobs.tsx Updated return type to React.JSX.Element
web/src/modules/Jobs/JobDetails/JobInformationPane.tsx Updated return type to React.JSX.Element
web/src/modules/Jobs/JobDetails/JobDetailsHeader.tsx Updated return type to React.JSX.Element
web/src/modules/Jobs/JobDetails/JobDetails.tsx Updated return type to React.JSX.Element
web/src/modules/Commands/Commands.tsx Updated return type to React.JSX.Element
web/src/modules/Commands/CommandDetails/CommandInformationPane.tsx Updated return type to React.JSX.Element
web/src/modules/Commands/CommandDetails/CommandDetailsHeader.tsx Updated return type to React.JSX.Element
web/src/modules/Commands/CommandDetails/CommandDetails.tsx Updated return type to React.JSX.Element
web/src/modules/Clusters/ClustersDetails/ClustersDetailsHeader.tsx Updated return type to React.JSX.Element
web/src/modules/Clusters/ClustersDetails/ClustersDetails.tsx Updated return type to React.JSX.Element
web/src/modules/Clusters/ClustersDetails/ClusterInformationPane.tsx Updated return type to React.JSX.Element
web/src/modules/Clusters/Clusters.tsx Updated return type to React.JSX.Element
web/src/components/ApiResponseButton/ApiResponseButton.tsx Updated return type to React.JSX.Element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants