React 19 ground work for heimdall #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR lays the groundwork for migrating to React 19 by updating all component return type definitions from JSX.Element to React.JSX.Element.
- Updated return type annotations for components in Jobs, Commands, and Clusters modules
- Standardized return types across multiple UI components to ensure consistency
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/modules/Jobs/Jobs.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Jobs/JobDetails/JobInformationPane.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Jobs/JobDetails/JobDetailsHeader.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Jobs/JobDetails/JobDetails.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Commands/Commands.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Commands/CommandDetails/CommandInformationPane.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Commands/CommandDetails/CommandDetailsHeader.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Commands/CommandDetails/CommandDetails.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Clusters/ClustersDetails/ClustersDetailsHeader.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Clusters/ClustersDetails/ClustersDetails.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Clusters/ClustersDetails/ClusterInformationPane.tsx | Updated return type to React.JSX.Element |
| web/src/modules/Clusters/Clusters.tsx | Updated return type to React.JSX.Element |
| web/src/components/ApiResponseButton/ApiResponseButton.tsx | Updated return type to React.JSX.Element |
JoshMDiaz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.