feat: add font size control to CodeEditorConfigurationModal example #12113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://pf-react-pr-12113.surge.sh A11y report: https://pf-react-pr-12113-a11y.surge.sh |
packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx
Outdated
Show resolved
Hide resolved
packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx
Show resolved
Hide resolved
thatblindgeye
requested changes
Nov 18, 2025
packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx
Show resolved
Hide resolved
thatblindgeye
approved these changes
Nov 19, 2025
Member
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
I just noticed a couple of typos; otherwise happy to sign off on this.
packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx
Outdated
Show resolved
Hide resolved
packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx
Outdated
Show resolved
Hide resolved
packages/react-code-editor/src/components/CodeEditor/examples/CodeEditorConfigurationModal.tsx
Outdated
Show resolved
Hide resolved
rebeccaalpert
approved these changes
Nov 21, 2025
Member
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
Let's ship it! Thank you for contributing.
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional issues: https://issues.redhat.com/browse/CONSOLE-4701