Skip to content

feat(CC-batch-1): updated component paths, small design alignment upd… #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(CC-batch-1): updated component paths, small design alignment upd… #11997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/code-connect/components/AboutModal/AboutModal.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { AboutModal, Button, Content } from '@patternfly/react-core';

figma.connect(
AboutModal,
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2879-13973&t=15CEJpGgVui7qP5Q-11',
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=2879-13973',
{
props: {
productName: figma.string('Product name')
Expand Down
10 changes: 5 additions & 5 deletions packages/code-connect/components/Accordion/Accordion.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@ import { Accordion } from '@patternfly/react-core';

figma.connect(
Accordion,
'https://www.figma.com/file/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6%3A-Components-Test?node-id=2621-623',
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=2621-623',
{
props: {
// enum
displaySize: figma.enum('Type', { 'Large Bordered': 'lg' }),
displaySize: figma.enum('Type', { 'Large bordered': 'lg' }),
isBordered: figma.enum('Type', {
Bordered: true,
'Large Bordered': true
'Large bordered': true
}),
togglePosition: figma.enum('Caret position', { Left: 'start' }),
togglePosition: figma.enum('Caret position', { 'At start': 'start' }),

children: figma.children('Accordion toggle')
},
example: (props) => (
<Accordion togglePosition={props.togglePosition} isBordered={props.isBordered} displaySize={props.displaySize}>
<Accordion isBordered={props.isBordered} displaySize={props.displaySize} togglePosition={props.togglePosition}>
{props.children}
</Accordion>
)
Expand Down
19 changes: 8 additions & 11 deletions packages/code-connect/components/Accordion/AccordionToggle.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,24 @@ import { AccordionItem, AccordionToggle, AccordionContent } from '@patternfly/re

figma.connect(
AccordionToggle,
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=1423-687',
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=1423-687',
{
props: {
// string
expandText: figma.string('Expand Text'),
expandedContentText: figma.string('Expanded content text'),
expandedToggleText: figma.string('Expanded toggle text'),
toggleText: figma.string('Toggle text'),

// enum
open: figma.enum('State', { Expanded: true }),
toggleTextExpanded: figma.enum('State', {
Default: figma.string('Toggle Text'),
Hover: figma.string('Toggle Text'),
Expanded: figma.string('Toggle Text Expanded')
})
isExpanded: figma.enum('State', { Expanded: true })
},
example: (props) => (
<AccordionItem isExpanded={props.open}>
<AccordionItem isExpanded={props.isExpanded}>
<AccordionToggle onClick={() => {}} id="<your-id>">
{props.toggleTextExpanded}
{props.expandedToggleText}
</AccordionToggle>
<AccordionContent id="accordion-content-example">
<p>{props.expandText}</p>
<p>{props.expandedContentText}</p>
</AccordionContent>
</AccordionItem>
)
Expand Down
2 changes: 1 addition & 1 deletion packages/code-connect/components/ActionList/ActionList.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { ActionList } from '@patternfly/react-core';

figma.connect(
ActionList,
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=6780-15839',
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=6780-15839',
{
props: {
// enum
Expand Down
2 changes: 1 addition & 1 deletion packages/code-connect/components/ClipboardCopy/ClipboardCopyBasic.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ClipboardCopy } from '@patternfly/react-core';

figma.connect(
ClipboardCopy,
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=9914-75835',
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=9914-75835',
{
props: {
// enum
Expand Down
2 changes: 1 addition & 1 deletion packages/code-connect/components/ClipboardCopy/ClipboardCopyInlineCompact.figma.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ClipboardCopy } from '@patternfly/react-core';

figma.connect(
ClipboardCopy,
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=9914-75768',
'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=2722-13543',
{
props: {
children: figma.children('*')
Expand Down
10 changes: 5 additions & 5 deletions packages/code-connect/figma.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
"codeConnect": {
"parser": "react",
"include": [
"components/DatePicker/*.tsx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you replacing these rather than adding to them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codebase is too large to publish comprehensively. Also, publishing large groups of code connect files is quite time intensive.

"components/EmptyState/*.tsx",
"components/FileUpload/*.tsx",
"components/Hint/*.tsx",
"components/InlineEdit/*.tsx"
"components/AboutModal/*.tsx",
"components/Accordion/*.tsx",
"components/ActionList/*.tsx",
"components/BackgroundImage/*.tsx",
"components/ClipboardCopy/*.tsx"
],
"paths": {
"src/components": "src/components"
Expand Down
Loading