Skip to content

feat: extend PopperProps in derivative component types #11934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2025
Merged

feat: extend PopperProps in derivative component types #11934

merged 3 commits into from
Sep 24, 2025

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jul 23, 2025 •
edited
Loading

What:
Closes #11929
Closes #11574

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 23, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11934.surge.sh

A11y report: https://patternfly-react-pr-11934-a11y.surge.sh

Preview: https://pf-react-pr-11934.surge.sh

A11y report: https://pf-react-pr-11934-a11y.surge.sh

@logonoff logonoff force-pushed the menucontainer branch 3 times, most recently from fb8e369 to cf608bc Compare July 23, 2025 20:17
@logonoff logonoff changed the title fix(MenuContainer): use PopperProps for MenuPopperProps feat: extend PopperProps in derivative component types Jul 23, 2025
wise-king-sullyman
wise-king-sullyman reviewed Jul 25, 2025
View reviewed changes
@logonoff logonoff force-pushed the menucontainer branch 3 times, most recently from 8f64e28 to 6ac728c Compare July 28, 2025 18:18
wise-king-sullyman
wise-king-sullyman approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

kmcfaul
kmcfaul reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with these changes is that the PopperProps interface is not visible on the site. Can we add the interface to each relevant md file's props array?

@logonoff
Copy link
Member Author

My only concern with these changes is that the PopperProps interface is not visible on the site. Can we add the interface to each relevant md file's props array?

Done

@nicolethoen nicolethoen merged commit b79c4d6 into patternfly:main Sep 24, 2025
13 checks passed
@logonoff logonoff deleted the menucontainer branch September 24, 2025 12:59
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - MenuContainer - MenuPopperProps is not fully described MenuContainer: popperProps Missing appendTo Property like in Select Component
6 participants
@logonoff @patternfly-build @wise-king-sullyman @nicolethoen @kmcfaul @thatblindgeye