-
Notifications
You must be signed in to change notification settings - Fork 145
docs(theming): Adds Figma guidance for using themes. #4847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I'll also add that our charts have a unique token collection, so there is also a mode toggle for Charts. Right now, the Charts just have Light & Dark support in our main figma library, but will have Light, Dark, Light - High Contrast, and Dark - High Contrast once those updates go through.
packages/documentation-site/patternfly-docs/content/design-guidelines/styles/theming/theming.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/design-guidelines/styles/theming/theming.md
Outdated
Show resolved
Hide resolved
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these updates look good! thanks erin!!
Closes #4823