Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to decide whether hash keys should be sorted #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haozhexu
Copy link

The hash keys are sorted which creates problems in use cases like simply editing and saving of existing plist, whose keys (in dictionaries) are not sorted but after saving the plist the whole file seems to me changed. This PR adds the option to not sort hash keys, by default it's true in order to be backward compatible with existing behaviour.

@patsplat
Copy link
Owner

Pardon the tardiness of my response.

If the output isn't sorted by key, would the hash end up being re-sorted arbitrarily because ruby hashes aren't sorted?

@patsplat
Copy link
Owner

Basically I'm not sure if this PR alone will do what you expect.

Note this library was originally developed to parse my iphoto library. It was being used on large plist files, with ruby 1.6.

I think I added the sort, way back when, because the output was always unpredictably different than expected. The sort in the output was arbitrary, but at least it made sense on some level.

If ruby hashes are now ordered, it could make sense to revisit this behavior. I'd prefer to ditch the sort entirely, though of course that may be a breaking change now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants