Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macOS support #50

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

RLittlesII
Copy link

No description provided.


namespace Cupboard
{
public sealed class BashScriptProvider : AsyncMacResourceProvider<BashScript>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bash Script is not exclusive to Mac 🤔

Windows has mingw bash and wsl bash.
Linux has bash :)

However, noted that you specified the CLI wrap for /bin/zsh which is default for mac.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. It doesn't belong to windows either. So I am open to suggestions on the taxonomy. I put it here because I was adding macOS support and it's the default on mac as you stated.

Likely need some guidance from @patriksvensson on where he'd like it to live and be pulled into macOS.

@@ -0,0 +1,2 @@
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=homebrew/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better as an editorconfig 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that how it's currently implemented and I missed it? Likely just me clicking buttons too fast during development trying to remove compiler warnings. I can remove this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants