Move process-architecture check to runtime #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progress 12 and up don't have a 32 bit compiler (that i'm aware off), but they do have 32 bit clients. this PR moves the process architecture check from compile time to runtime so a version compiled in 64 bit can be run on 32 bit clients. tested and validated on version: - 10.2B07 32-bit - 11.7.14 32-bit - 11.7.15 64-bit - 12.2.12 32-bit (compiled using 12.2.10 64-bit) - 12.2.10 64-bit
Owner
|
Hi Sil,
Big thanks for this pr. I surely will integrate this, but the thing is, I
am working on a rather large update where I pull apart lots of code for the
index and fields tab. I do this in order to add more tabs and make the code
more maintainable. This might take a while since I am quite busy, but be
assured that I will use it!
Patrick
Op zo 7 jan. 2024 15:49 schreef Sil-Boydens ***@***.***>:
… progress 12 and up don't have a 32 bit compiler (that i'm aware off), but
they do have 32 bit clients. this PR moves the process-architecture check
from compile time to runtime so a version compiled in 64 bit can be run on
32 bit clients.
tested and validated on version:
- 10.2B07 32-bit
- 11.7.14 32-bit
- 11.7.15 64-bit
- 12.2.12 32-bit (compiled using 12.2.10 64-bit)
- 12.2.10 64-bit
------------------------------
You can view, comment on, or merge this pull request online at:
#103
Commit Summary
- ecf8101
<ecf8101>
Move process-architecture check to runtime
File Changes
(6 files <https://github.com/patrickTingen/DataDigger/pull/103/files>)
- *M* DataDigger2.p
<https://github.com/patrickTingen/DataDigger/pull/103/files#diff-c7b514579f91b355c0295356406cbe1ecb2213848f3b8f53922eeb423bff0eee>
(4)
- *M* DataDiggerLib.p
<https://github.com/patrickTingen/DataDigger/pull/103/files#diff-27386ec31d977631cb78920246e01097cd943ef734b4f19f03da422e58999401>
(8)
- *A* DataDiggerLib32.p
<https://github.com/patrickTingen/DataDigger/pull/103/files#diff-791fc4206a729c125351216dae2e2403dfe6e538635a95589282f8a41ea9ead0>
(1)
- *A* DataDiggerLib64.p
<https://github.com/patrickTingen/DataDigger/pull/103/files#diff-b852c4393dd32e8a638f1f867694debb49229bbea197afc18e472a889c9444de>
(1)
- *A* getProcessArchitecture.p
<https://github.com/patrickTingen/DataDigger/pull/103/files#diff-bcca40a27310e47362ad9568c5fb4de96729337b42adc6ca57c854a64c1f1429>
(2)
- *M* startDiggerLib.p
<https://github.com/patrickTingen/DataDigger/pull/103/files#diff-5e29002c49107138085910248bc8ed1353a821bbc0c52296536baa49fffa7b47>
(18)
Patch Links:
- https://github.com/patrickTingen/DataDigger/pull/103.patch
- https://github.com/patrickTingen/DataDigger/pull/103.diff
—
Reply to this email directly, view it on GitHub
<#103>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN3AHKOY454TMOZ3C3ZYNDYNKYWPAVCNFSM6AAAAABBQL7TL6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DSMJVHEYTGNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
Hi Patrick, No worries, i was already aware of the big rewrite for those tabs. |
Owner
|
Sounds like a good plan, I will do that.
Thanks again for your help!
…--
Patrick Tingen
Op zo 7 jan 2024 om 17:09 schreef Sil-Boydens ***@***.***>:
Hi Patrick,
No worries, i was already aware of the big rewrite for those tabs.
You don't have to merge this, just copying the underlying idea is also
possible.
Just leave the PR open until this functionality is in the main release, so
people that need this can find it.
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN3AHPDHFXZZ47GN2JARELYNLCDNAVCNFSM6AAAAABBQL7TL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGEYDANJQHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress 12 and up don't have a 32 bit compiler (that i'm aware off), but they do have 32 bit clients. this PR moves the process-architecture check from compile time to runtime so a version compiled in 64 bit can be run on 32 bit clients.
tested and validated on version: