Merge changes from on2itsecurity #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an attachment whenever the `Content-Disposition` header says it is this fixes a problem where `text/plain` attachments were interpreted as belonging to the TextBody
simplified behaviour of attachments in multipart/mixed: a mime part i…
don't fail on empty mime parts
fixed panic on maliciously crafter Content-Disposition mime headers
…pports in word-encoded mail & mime headers like From, Subject and attachment filenames
added support for all charsets that https://github.com/golang/text su…
…ted multipart/mixed mimeparts I tried to do the same for multipart/mixed that contains multipart/related, but because the semantics of those are a bit more complex in regards to content-disposition (eg. plain-text attachments), this isn't as simple. We haven't seen them in the wild yet, so I don't want to break stuff without actually fixing a real problem.
don't lose previously parsed text & html parts
…-encodings Fix fallback for unsupported encodings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.