fix u_mouse and u_resolution #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimation cancelAnimationFrame
edap
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a weird issue with the u_mouse uniform while mapping the mouse to the center of the screen using:
Then I have noticed that the u_mouse and the u_resolution are passed in different scale. The mouse values where multiplied by this.realToCSSPixels, while the mouse no. I have mutliplied also the the resolution by this.realToCSSPixels, and now u_mouse and u_resolution are under the same scale factor.
After changing the glslCanvas file I have also run the build, that's why some changes are also into the dist folder.