lazy initialize uniform.location #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is untested but should be a performance boost when uniforms are set frequently.
|
Mmmm.... the thing is glslCanvas (that's use by glslEditor) have as a core feature of allowing you to reload different vert/frag shaders. Seams like keeping a record of the location will prevent access for future locations in case the code change and new shader programs are running |
|
I see. In that case, this patch is no good by itself. I can dig in some more -- maybe it's possible to cache it and clear the cache when the shaders change? |
|
yes, that makes a lot of sense... some sort of flag that keep track on when shaders change? right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested but should be a performance boost when uniforms are set frequently.