fix(stream): correct cached input accounting - #31
Merged
Conversation
patlux
approved these changes
Aug 3, 2026
patlux
left a comment
Owner
There was a problem hiding this comment.
Verified the token semantics against the Vercel AI SDK usage schema and the provider implementations used by Command Code. The fix correctly separates uncached input, cache reads, and cache writes. Added regression coverage for the fallback without noCacheTokens and for cacheWriteTokens; local tests and CI are green.
Owner
|
Thank you @IfkumRfnl for reporting this with a concrete API example and providing the fix! I independently verified the usage semantics against the Vercel AI SDK and the provider implementations used by Command Code. I also added coverage for the fallback path and cache-write accounting. Everything is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputTokenDetails.noCacheTokensfor uncached input usage.Command Code's
inputTokensincludes cached tokens. Treating it as uncached input caused cache reads to be counted twice in pi's usage totals, cost estimates, and context accounting.Testing
npm run typechecknpm run test:unitnpm run test:streamnpm run format:checkdeepseek/deepseek-v4-flashFixes #30