-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customProperties to register/authenticate #83
Add customProperties to register/authenticate #83
Conversation
Hi @Paul-Taiwo . Thank you very much for this PR. Although it's good, I slightly hesitate to accept it for various small reasons.
Actually, I'm more inclined to revert the random user.id generation (it was a hash of the username before) or add an option to add arbitrary properties. |
Hi @dagnelies Thank you for your feedback on my earlier PR. I’ve taken your suggestions into account and have made the following updates:
|
Sounds great 👍 What do you think about adding the custom properties to both the registration and authentication? I think it would be more versatile and intuitive that way. Also, the docs must be updated so that people are aware this even exists. Besides this nitpicking, it looks good and meaningful. Thanks for the contribution |
Hi @dagnelies, |
This PR introduces the
excludeCredentials
property to the passkey creation flow. This feature enhances the security and usability of the passkey creation process by preventing duplicate registrations of credentials associated with the same user.