chore: [sc-135584] CLI Node 22 #875
Conversation
| WIFI_CREDS_FILE | ||
| } = require('../lib/env'); | ||
| const stripAnsi = require('strip-ansi'); | ||
| const { default: stripAnsi } = require('strip-ansi'); |
There was a problem hiding this comment.
Why this change was required?
Other elements still accepting:
const something = require('my-lib')
There was a problem hiding this comment.
I upgraded strip-ansi to latest where it became an ESM only library. That means it now has an ESM default export which node does not handle for us with require, so you need to grab the default and rename it to what you want or do a require('thing').default
I don't have a strong opinion on either option
| "node16-macos-x64", | ||
| "node16-macos-arm64", | ||
| "node16-win-x64", | ||
| "node16-linux-arm", |
There was a problem hiding this comment.
Is this not required anymore? linux-arm
There was a problem hiding this comment.
The upgraded pkg said linux-arm doesn't exist and we only have 64 bit builds for other platforms, so I figured it was probably fine to drop. @monkbroc do you know why we had linux-arm in here?
There was a problem hiding this comment.
linux-arm was for the Raspberry Pi 1 ARMv6 (32-bit), Pi Zero ARMv6 (32-bit) and 2 ARMv7 (32-bit). Raspberry 2 (v1.2) and later Pis (3, 4, 5, Zero 2 W) use ARMv8 (64-bit).
Yes, it's ok to drop linux-arm at this point.
cole-abbeduto-particle
temporarily deployed
to
staging
GitHub Actions
Inactive
3 participants
Story details: https://app.shortcut.com/particle/story/135584