Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions spec/ParseUser.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,59 @@ describe('Parse.User testing', () => {
}
});

it('logs username taken with configured log level', async () => {
await reconfigureServer({ logLevels: { usernameAlreadyExists: 'warn' } });
const logger = require('../lib/logger').default;
loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
const loggerWarnSpy = spyOn(logger, 'warn').and.callThrough();

const user = new Parse.User();
user.setUsername('dupUser');
user.setPassword('pass');
await user.signUp();

const user2 = new Parse.User();
user2.setUsername('dupUser');
user2.setPassword('pass2');

expect(loggerWarnSpy).not.toHaveBeenCalled();

try {
await user2.signUp();
fail('should have thrown');
} catch (e) {
expect(e.code).toBe(Parse.Error.USERNAME_TAKEN);
}

expect(loggerWarnSpy).toHaveBeenCalledTimes(1);
expect(loggerErrorSpy.calls.count()).toBe(0);
});

it('can silence username taken log event', async () => {
await reconfigureServer({ logLevels: { usernameAlreadyExists: 'silent' } });
const logger = require('../lib/logger').default;
loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
const loggerWarnSpy = spyOn(logger, 'warn').and.callThrough();

const user = new Parse.User();
user.setUsername('dupUser');
user.setPassword('pass');
await user.signUp();

const user2 = new Parse.User();
user2.setUsername('dupUser');
user2.setPassword('pass2');
try {
await user2.signUp();
fail('should have thrown');
} catch (e) {
expect(e.code).toBe(Parse.Error.USERNAME_TAKEN);
}

expect(loggerWarnSpy).not.toHaveBeenCalled();
expect(loggerErrorSpy.calls.count()).toBe(0);
});

it('user login with context', async () => {
let hit = 0;
const context = { foo: 'bar' };
Expand Down
6 changes: 6 additions & 0 deletions src/Options/Definitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -1506,4 +1506,10 @@ module.exports.LogLevels = {
'Log level used by the Cloud Code Triggers `beforeSave`, `beforeDelete`, `beforeFind`, `beforeLogin` on success. Default is `info`. See [LogLevel](LogLevel.html) for available values.',
default: 'info',
},
usernameAlreadyExists: {
env: 'PARSE_SERVER_LOG_LEVELS_USERNAME_ALREADY_EXISTS',
help:
'Log level used when a sign-up fails because the username already exists. Default is `error`. See [LogLevel](LogLevel.html) for available values.',
default: 'error',
},
};
1 change: 1 addition & 0 deletions src/Options/docs.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/Options/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -789,4 +789,8 @@ export interface LogLevels {
:DEFAULT: error
*/
cloudFunctionError: ?string;
/* Log level used when a sign-up fails because the username already exists. Default is `error`. See [LogLevel](LogLevel.html) for available values.
:DEFAULT: error
*/
usernameAlreadyExists: ?string;
}
14 changes: 13 additions & 1 deletion src/middlewares.js
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,8 @@ export function handleParseErrors(err, req, res, next) {
if (req.config && req.config.enableExpressErrorHandler) {
return next(err);
}
const usernameAlreadyExistsLevel =
req.config?.logLevels?.usernameAlreadyExists || 'info';
let httpStatus;
// TODO: fill out this mapping
switch (err.code) {
Expand All @@ -480,7 +482,17 @@ export function handleParseErrors(err, req, res, next) {
}
res.status(httpStatus);
res.json({ code: err.code, error: err.message });
log.error('Parse error: ', err);
if (err.code === Parse.Error.USERNAME_TAKEN) {
if (usernameAlreadyExistsLevel !== 'silent') {
const loggerMethod =
typeof log[usernameAlreadyExistsLevel] === 'function'
? log[usernameAlreadyExistsLevel].bind(log)
: log.error.bind(log);
loggerMethod('Parse error: ', err);
}
} else {
log.error('Parse error: ', err);
}
} else if (err.status && err.message) {
res.status(err.status);
res.json({ error: err.message });
Expand Down
1 change: 1 addition & 0 deletions types/Options/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -297,5 +297,6 @@ export interface LogLevels {
triggerBeforeError?: string;
cloudFunctionSuccess?: string;
cloudFunctionError?: string;
usernameAlreadyExists?: string;
}
export {};
Loading