-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
refactor: Bump redis from 4.7.0 to 5.1.0 #9765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will reformat the title to use the proper commit message syntax. |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe change updates the Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to a dependency version update. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
690a69c
to
f156413
Compare
@coderabbitai review |
✅ Actions performedReview triggered.
|
@coderabbitai Are there any code changes necessary for this dependency upgrade not to break anything? |
You are on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade to CodeRabbit Pro. |
1 similar comment
You are on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade to CodeRabbit Pro. |
f156413
to
14e2cbd
Compare
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
59-59
:❓ Verification inconclusive
Verify Redis v5.1.0 client upgrade compatibility
Bumping the major version of the Redis client may introduce breaking API changes (e.g., RESP3 defaults, Sentinel integration, command import locations, connection options). Ensure that allcreateClient
calls, command imports, and any custom type mappings are updated and validated.Run this script to locate and review Redis client usage throughout the codebase:
🏁 Script executed:
#!/bin/bash # Search for Redis client instantiations to verify API compatibility. rg -n "createClient(" --glob "*.js" --glob "*.ts"Length of output: 128
🏁 Script executed:
#!/bin/bash # Search for Redis client instantiations to verify API compatibility. # 1) createClient calls (escape the parenthesis) rg -n "createClient\(" --glob "*.js" --glob "*.ts" # 2) ES module imports of createClient rg -n "import .*createClient" --glob "*.js" --glob "*.ts" # 3) CommonJS require of redis rg -n "require('redis')" --glob "*.js" --glob "*.ts"Length of output: 1147
Verify Redis v5.1.0 client upgrade compatibility
We’ve located allcreateClient
usages—please manually review each location against the v5.x API changes (RESP3 defaults, URL-based connections, command invocation, type mappings, etc.):• src/middlewares.js
– import{ createClient }
from ‘redis’ at line 14
–createClient({ … })
call at line 538• src/Adapters/Cache/RedisCacheAdapter.js
– import{ createClient }
from ‘redis’ at line 1
–this.client = createClient(...)
at line 18• src/Adapters/PubSub/RedisPubSub.js
– import{ createClient }
from ‘redis’ at line 1
– twocreateClient({ … })
calls at lines 6 and 16Key areas to confirm:
- Connection options use the new
{ url: … }
format- RESP3 is enabled by default (adjust any multi-bulk or streaming logic)
- Commands must be invoked on the returned client instance (no more static imports)
- Any custom TypeScript interfaces/types for Redis commands or responses are up to date
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
(1 hunks)
14e2cbd
to
c9adb25
Compare
Bumps [redis](https://github.com/redis/node-redis) from 4.7.0 to 5.1.0. - [Release notes](https://github.com/redis/node-redis/releases) - [Changelog](https://github.com/redis/node-redis/blob/master/CHANGELOG.md) - [Commits](https://github.com/redis/node-redis/compare/[email protected]@5.1.0) --- updated-dependencies: - dependency-name: redis dependency-version: 5.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
c9adb25
to
6df325b
Compare
Superseded by #9778. |
Bumps redis from 4.7.0 to 5.1.0.
Release notes
Sourced from redis's releases.
... (truncated)
Commits
ab399a8
Release [email protected]78c6d60
Updated the Redis package to use [email protected]8d34ee2
Release [email protected]7fca460
Updated the Timeseries package to use [email protected]2cc6864
Release [email protected]4bb2328
Updated the Search package to use [email protected]a485936
Release [email protected]a1b41e2
Updated the Json package to use [email protected]f2a3c1b
Release [email protected]e938bda
Updated the Entraid package to use [email protected]Maintainer changes
This version was pushed to npm by nkaradzhov, a new releaser for redis since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit