feat: Add SecureEncoder support to PFFileObject#1768
Closed
dhoerl wants to merge 4 commits intoparse-community:masterfrom
dhoerl:pffileobject-secure-coding
Closed
feat: Add SecureEncoder support to PFFileObject#1768dhoerl wants to merge 4 commits intoparse-community:masterfrom dhoerl:pffileobject-secure-coding
dhoerl wants to merge 4 commits intoparse-community:masterfrom
dhoerl:pffileobject-secure-coding
Conversation
Thanks for opening this pull request!
|
|
I will reformat the title to use the proper commit message syntax. |
Member
|
Would you want to add a test so we can merge this? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1768 +/- ##
===========================================
+ Coverage 64.24% 82.76% +18.52%
===========================================
Files 201 282 +81
Lines 23233 30741 +7508
===========================================
+ Hits 14926 25443 +10517
+ Misses 8307 5298 -3009 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
PFFileObjects can be used outside of a PFObject subclass. When archiving them and other objects using the NSSecureEncoder, the encoder now fails with an error that PFFileObjects are not secure coding compliant.
Fine - in Objective-C, I create a class extension to add it. Works fine. However, when I go to change that extension to Swift, the compilation fails with the error that NSSecureCoding cannot be added in a class extension (but must be done by the original class).
Closes: #1736
Approach
Add NSSecureCoding to PFFileObject:
supportsSecureCodingPFEncoder objectEncoderPFDecoder objectDecoderTODOs before merging