fix: pre-existing CI failures (lockfile, validator test, perf tests) - #282
Merged
Merged
Conversation
…excluded, mobile npm install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #229
Changes
npm installinstead ofnpm ci(no lockfile in mobile)Root Causes
package-lock.jsonwas out of sync withpackage.jsonafter someone added react-hook-form and changed zod version without regenerating the lockfileIssuerAccounttest addressGD6WU5...FIEIFhas an invalid checksum — not a real Stellar addressassetforgedatabase that doesn't exist in CI, then proceed to make HTTP requests to a server that isn't running, eventually timing out at 10mpackage-lock.jsonexists in mobile/ sonpm cifailsCloses: #279