Skip to content

Extended feats#48

Merged
davxy merged 11 commits intoparitytech:masterfrom
davxy:extended-feats
Feb 21, 2025
Merged

Extended feats#48
davxy merged 11 commits intoparitytech:masterfrom
davxy:extended-feats

Conversation

@davxy
Copy link
Member

@davxy davxy commented Feb 20, 2025

This is the additional stuff we currently use in JAM,

  • User provides the padding point. Consequently I removed "try and increment" h2c as it is dead code now
    • just use a random point for tests
  • test_vectors feature: Use zeros for ZK rows to easily reproduce test vectors without ugly hacks
  • Use ArkTranscript by default: is should be ok for most of use cases and dependency is already not optional
  • API consistence: RingVerifier::verify_ring_proof rename to RingVerifier::verify (as we have RingProver::prove)
  • Add repo reference (Used by crates.io / docs.rs)

NOTES:

  • You may want to merge this first: Add repository reference fflonk#44
  • Once this PR has been merged to master, please wait to release it on crates.io. I would like to give it an additional run.

Ty

@davxy davxy changed the title [DIFF] Extended feats [WiP] Extended feats Feb 20, 2025
@davxy davxy changed the title [WiP] Extended feats [WiP - DO NOT MERGE] Extended feats Feb 20, 2025
@davxy davxy requested review from drskalman and swasilyev February 20, 2025 12:05
@davxy davxy changed the title [WiP - DO NOT MERGE] Extended feats Extended feats Feb 20, 2025
Copy link
Collaborator

@drskalman drskalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davxy davxy merged commit 691cf0a into paritytech:master Feb 21, 2025
5 checks passed
@davxy davxy deleted the extended-feats branch February 21, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants