Support AdvancePc and ConstantAddPc
#350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike `SetAddress` and `FixedAddPc` which set absolute addresses (and thus need relocation handling), these instructions work by advancing the PC relative to the current address
Author
|
jfyi: this will unblock switching to LLVM 21 in revive compiler. |
kvpanch
changed the title
AdvancePc and ConstantAddPcAdvancePc and ConstantAddPc
Collaborator
|
The last I touched this code was ages ago, but unless I'm missing something these also might need relocation handling like For reference, can you upload an example binary which uses these? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
SetAddressandFixedAddPcwhich set absolute addresses (and thus need relocation handling), these instructions work by advancing the PC relative to the current address