🚧 Introduce pallet-dap-satellite and redirect all burns for native tokens to DAP/ DAP satellite on Westend runtimes #10597
+2,003
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an initial version of the Dynamic Allocation Pool (DAP). It makes possible to collect funds that would otherwise be burned, into the DAP buffer on AssetHub. On Westend AssetHub: - Treasury unspent and staking slashes are now redirected to the DAP buffer instead of being burned. - All user-initiated burns also go to the DAP buffer instead of reducing total issuance. Events: - FundsReturned is emitted only for explicit user actions (e.g., burn extrinsic via FundingSink). Automatic system operations like fee handling and slashes via OnUnbalanced do NOT emit events to avoid bloating blocks with tons of events per block.
This is done in order to reduce the scope of the initial changes. We comment out the BurnDestination from pallet-balances config so that we avoid to introduce a breaking change for all runtimes. This is initially acceptable since burn extrinsic is rarely used.
sigurpol
added
T2-pallets
sigurpol
changed the title
sigurpol
changed the title
sigurpol
force-pushed
the
sigurpol-dap-satellite
branch
from
4ecbd80 to
5025686
Compare
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
…havior - Add BurnHandler trait called after decrease_balance in burn_from - FundingSink now extends BurnHandler - DirectBurn::on_burned reduces total issuance (traditional burning) - DAP handlers use increase_balance to credit buffer (tokens preserved) - Override burn_from in pallet-balances to call T::BurnDestination::on_burned
sigurpol
force-pushed
the
sigurpol-dap-satellite
branch
from
137b6f5 to
ee054ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces
pallet-dap-satellite, allowing system chains different from AssetHub to collect funds (to be periodically sent to DAP on AssetHub in future PRs) instead of burning them directly.It also make any burns (initiated by the user via extrinsic or by a pallet) configurable (direct burn vs redirect to a buffer).
NOTE: until #10576 is merged, I am just building on top of that PR, for the reviewers: just look at delta between 10576 and this PR.
✨ Changes
pallet-dap-satellite: New pallet that implements
FundingSinkby accumulating funds in a satellite account.[breaking change] pallet-balances:
BurnDestinationis now a required config item that must implementBurnHandler. TheBurnHandler::on_burnedmethod is called afterdecrease_balanceremoves funds from an account, allowing each runtime to choose whether burns lead to direct burning (reducing total issuance) or redirecting to a buffer.Runtimes must explicitly configure this:
frame_support::traits::tokens::DirectBurn<Balances, AccountId>pallet_dap::ReturnToDap<Runtime>(on AssetHub) orpallet_dap_satellite::AccumulateInSatellite<Runtime>(on other system chains)Note that non-native asset burns via pallet-assets do not use pallet-balances's implementation of BurnHandler but they rely on the default one: each asset in pallet-assets has its own supply that should decrease when burned.
frame-support: New
BurnHandlertrait thatFundingSinknow extends.DirectBurnimplementsBurnHandler::on_burnedto reduce total issuance.🚀 Runtime integrations:
DirectBurnwhich burns native tokens directly🚧 TODO
🔜 Coming next
In future PRs, we will hook the logic to periodically send funds from the satellite to the main DAP on AssetHub.
Related PRs / issues
Followup of #10576.
Close #10488.