Skip to content

[stable2509] Backport #9791 #10531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorPopelyaev merged 3 commits into from
Dec 9, 2025
Merged

[stable2509] Backport #9791 #10531

EgorPopelyaev merged 3 commits into from
Dec 9, 2025

Conversation

@paritytech-release-backport-bot
Copy link

@paritytech-release-backport-bot paritytech-release-backport-bot bot commented Dec 3, 2025

Backport #9791 into stable2509 from bkchr.

See the documentation on how to use this bot.

@bkchr @github-actions
revive-fixtures: Provide an env variable to disable compilation (#9791)
5d1cde6 
Right now `pallet-revive-fixtures` is always trying to build the
fixtures. It requires `solc` and other stuff for compilation. If you are
not requiring the fixtures, because you for example only run `cargo
check`, this pull request introduces `SKIP_PALLET_REVIVE_FIXTURES`. When
the environment variable is set, the compilation of the fixtures is
skipped. It will set the fixtures to `None` and they will panic at
runtime.

(cherry picked from commit 277a265)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 3, 2025
@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Dec 3, 2025
Merged
@github-actions github-actions bot requested a review from bkchr December 3, 2025 17:44
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Dec 4, 2025
@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) December 7, 2025 17:35
@EgorPopelyaev EgorPopelyaev merged commit f53beff into stable2509 Dec 9, 2025
245 of 252 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-9791-to-stable2509 branch December 9, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

Assignees

No one assigned

Labels

A3-backport Pull request is already reviewed well in another branch. R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkchr @EgorPopelyaev