fix(rpc-spec-v2): best block not announced immediately after initialised #10525
+137
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cmd label T0-node |
Contributor
Author
|
/cmd prdoc |
Contributor
|
Command "label T0-node" has failed ❌! See logs here |
jsdw
approved these changes
Dec 3, 2025
lexnv
added
T0-node
lexnv
reviewed
Dec 3, 2025
prdoc/pr_10525.prdoc
Outdated
Comment on lines
25
to
38
| ## Review Notes | ||
|
|
||
| This PR removes that condition so that the `bestBlockChanged` notification is always emited. All tests are updated to this new behaviour | ||
|
|
||
| # Checklist | ||
|
|
||
| * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. | ||
| * [ ] My PR follows the [labeling requirements]( | ||
| https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process | ||
| ) of this project (at minimum one label for `T` required) | ||
| * External contributors: Use `/cmd label <label-name>` to add labels | ||
| * Maintainers can also add labels manually | ||
| * [x] I have made corresponding changes to the documentation (if applicable) | ||
| * [x] I have added tests that prove my fix is effective or that my feature works (if applicable) |
Contributor
There was a problem hiding this comment.
nit: lets remove the checklist from the prdoc, is added by default but not really related to our release process
lexnv
added
A4-backport-stable2509
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
paritytech:master
with commit Dec 5, 2025
68c1250
253 of 255 checks passed
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…sed (#10525) # Description Fixes polkadot-api/polkadot-api#1244 The current chainHead_v1 implementation is [not spec-compliant](https://paritytech.github.io/json-rpc-interface-spec/api/chainHead_v1_follow.html), as it states: > - Generates an `initialized` notification > - Generates one `newBlock` notification for each non-finalized block > - Then a `bestBlockChanged` notification > - When a new block arrives, generates a `newBlock` notification > - When the node finalizes a block, generates a `finalized` notification And the current implemention only emits the `bestBlockChanged` notification after initialized iif the best block is different from the finalized block. PAPI recently is using this part of the spec as an assumption. Most chains are unaffected, but those that produce blocks on-demand (e.g. manual-seal) then have polkadot-api hanging until there's a higher block different than the finalized one. ## Integration This PR doesn't change any of the APIs of the node. Upgrade should be automatic. ## Review Notes This PR removes that condition so that the `bestBlockChanged` notification is always emited. All tests are updated to this new behaviour # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [x] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: Use `/cmd label <label-name>` to add labels * Maintainers can also add labels manually * [x] I have made corresponding changes to the documentation (if applicable) * [x] I have added tests that prove my fix is effective or that my feature works (if applicable) --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexandru Vasile <[email protected]> (cherry picked from commit 68c1250)
|
Successfully created backport PR for |
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…sed (#10525) # Description Fixes polkadot-api/polkadot-api#1244 The current chainHead_v1 implementation is [not spec-compliant](https://paritytech.github.io/json-rpc-interface-spec/api/chainHead_v1_follow.html), as it states: > - Generates an `initialized` notification > - Generates one `newBlock` notification for each non-finalized block > - Then a `bestBlockChanged` notification > - When a new block arrives, generates a `newBlock` notification > - When the node finalizes a block, generates a `finalized` notification And the current implemention only emits the `bestBlockChanged` notification after initialized iif the best block is different from the finalized block. PAPI recently is using this part of the spec as an assumption. Most chains are unaffected, but those that produce blocks on-demand (e.g. manual-seal) then have polkadot-api hanging until there's a higher block different than the finalized one. ## Integration This PR doesn't change any of the APIs of the node. Upgrade should be automatic. ## Review Notes This PR removes that condition so that the `bestBlockChanged` notification is always emited. All tests are updated to this new behaviour # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [x] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: Use `/cmd label <label-name>` to add labels * Maintainers can also add labels manually * [x] I have made corresponding changes to the documentation (if applicable) * [x] I have added tests that prove my fix is effective or that my feature works (if applicable) --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexandru Vasile <[email protected]> (cherry picked from commit 68c1250)
|
Successfully created backport PR for |
EgorPopelyaev
added a commit
that referenced
this pull request
Dec 9, 2025
Backport #10525 into `stable2509` from voliva. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Victor Oliva <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexandru Vasile <[email protected]> Co-authored-by: Egor_P <[email protected]>
EgorPopelyaev
added a commit
that referenced
this pull request
Dec 9, 2025
Backport #10525 into `stable2512` from voliva. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Victor Oliva <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexandru Vasile <[email protected]> Co-authored-by: Egor_P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes polkadot-api/polkadot-api#1244
The current chainHead_v1 implementation is not spec-compliant, as it states:
And the current implemention only emits the
bestBlockChangednotification after initialized iif the best block is different from the finalized block.PAPI recently is using this part of the spec as an assumption. Most chains are unaffected, but those that produce blocks on-demand (e.g. manual-seal) then have polkadot-api hanging until there's a higher block different than the finalized one.
Integration
This PR doesn't change any of the APIs of the node. Upgrade should be automatic.
Review Notes
This PR removes that condition so that the
bestBlockChangednotification is always emited. All tests are updated to this new behaviourChecklist
Trequired)/cmd label <label-name>to add labels