forked from foundry-rs/compilers
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: Add initial Revive support(Take #2) #5
Draft
pkhry
wants to merge
25
commits into
main
Choose a base branch
from
pkhry/compiler-trait-approach
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,947
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brianspha
reviewed
Mar 7, 2025
} | ||
|
||
impl Default for Resolc { | ||
fn default() -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt the default method always meant to pass? I see that we throwing errors here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See this issue
See this PR for overall description
Difference from the
Multicompiler
approachResolc
compiler by hand and use the compiler directly in place ofMultiCompiler
used
solc@0.8.28+commit.7893614a.Darwin.appleclang
andresolc@0.1.0-dev.10+commit.ee650cf.llvm-18.1.8
for testing.Issues
TempProject relies on using MultiCompiler in some places so this makes integration testing way harder
#[rstest]
will no work in a lot of the cases because tests explicitely assume use ofMultiCompiler
instead ofCompiler
trait.Possible difficulties integrating into
foundry
directly asfoundry
just usesMultiCompiler
in a lot of the places instead of leveraging theCompiler
trait.Yul
output should in which form? We now fail right now as we can't construct a full contract from one field.TODOs