Add EVM backend support #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c5c7b1.
alexggh
reviewed
Oct 24, 2025
| pub enum Item { | ||
| Data(Vec<u8>), | ||
| Array(Vec<Item>), | ||
| Array(Vec<Self>), |
There was a problem hiding this comment.
why are this change needed, they don't seem related to the PR
There was a problem hiding this comment.
It is reported by clippy
| prj.update_config(|config| config.evm_version = EvmVersion::Cancun); | ||
|
|
||
| let res = cmd.args(["test", "--resolc", "-vvv", "--resolc-startup"]).assert(); | ||
| let res = cmd.args(["test", "--resolc", "-vvv", "--polkadot"]).assert(); |
There was a problem hiding this comment.
shouldn't we also run all of our revive tests with revive evm now ?
There was a problem hiding this comment.
yes I will add them, when I have bytecode migration in place - I need to add functionality in pallet-revive
|
This part needs updating as well: foundry-polkadot/crates/forge/src/runner.rs Line 447 in adb0ab7 forge test.
|
|
Ran this with the tests from #334 and can confirm they are passing with REVM as the backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #294
Flags combination for the
forge testcommandTODO in next PRs: