Add support for etch cheatcode #345
Conversation
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
force-pushed
the
alexggh/etch_support
branch
from
123974f to
b6a78d1
Compare
|
|
||
| execute_with_externalities(|externalities| { | ||
| externalities.execute_with(|| { | ||
| let contract_blob = Pallet::<Runtime>::try_upload_pvm_code( |
There was a problem hiding this comment.
a stupid question here: is the functionality required for doing etch with evm contracts is exposed too on pallet-revive side if we need it later?
There was a problem hiding this comment.
Not stupid at all it was on my list and after #345.
There was a problem hiding this comment.
try_upload_pvm_code charge gas for the execution and deposit from the caller account, is it OK in context of the test or it should be for free? I am not sure how is it done in Foundry standard REVM - do they charge any gas?
There was a problem hiding this comment.
@filip-parity as you are looking into gas could you please take a look how we should handle this? Probably upload call should be for free, REVM in foundry charges for opcodes only as I remember
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Depends of: paritytech/polkadot-sdk#9984
Developed on top of: #334.