Skip to content

Fix for ring-proof batching #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burdges merged 2 commits into from
Jan 30, 2026
Merged

Fix for ring-proof batching #46

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e234b0
Fix for batching
davxy Jan 28, 2026
8cef5ad
Revert Clone bound
davxy Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pcs/kzg/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@ impl<E: Pairing> RawVerifierKey for RawKzgVerifierKey<E> {
#[derive(Clone, Debug)]
pub struct KzgVerifierKey<E: Pairing> {
// generator of G1
pub(crate) g1: E::G1Affine,
pub g1: E::G1Affine,
// G1Prepared is just a wrapper around G1Affine // TODO: fixed-base precomputations
// generator of G2, prepared
pub(crate) g2: E::G2Prepared,
pub g2: E::G2Prepared,
// G2Prepared can be used as a pairing RHS only
// tau.g2, prepared
pub(crate) tau_in_g2: E::G2Prepared, // G2Prepared can be used as a pairing RHS only
pub tau_in_g2: E::G2Prepared, // G2Prepared can be used as a pairing RHS only
}

impl<E: Pairing> VerifierKey for KzgVerifierKey<E> {}
Expand Down
4 changes: 2 additions & 2 deletions src/pcs/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ pub trait RawVerifierKey:
fn prepare(&self) -> Self::VK;
}

pub trait PcsParams {
pub trait PcsParams: Clone {
type CK: CommitterKey;
type VK: VerifierKey;
type RVK: RawVerifierKey<VK = Self::VK>;
Expand All @@ -73,7 +73,7 @@ pub trait PcsParams {
}

/// Polynomial commitment scheme.
pub trait PCS<F: PrimeField> {
pub trait PCS<F: PrimeField>: Clone {
type C: Commitment<F>;

type Proof: Clone + CanonicalSerialize + CanonicalDeserialize;
Expand Down
Loading