Fix use after free in kqueue backend

parcel-bundler · Jan 25, 2025 · ab5da2f · ab5da2f
1 parent de6f13d
commit ab5da2f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/kqueue/KqueueBackend.cc b/src/kqueue/KqueueBackend.cc
@@ -83,6 +83,7 @@ void KqueueBackend::start() {
         std::vector<KqueueSubscription *> subs = findSubscriptions(entry->path);
         for (auto it = subs.begin(); it != subs.end(); it++) {
           KqueueSubscription *sub = *it;
+          watchers.insert(sub->watcher);
           if (flags & (NOTE_DELETE | NOTE_RENAME | NOTE_REVOKE)) {
             sub->watcher->mEvents.remove(sub->path);
             sub->tree->remove(sub->path);
@@ -96,8 +97,6 @@ void KqueueBackend::start() {
               sub->watcher->mEvents.update(sub->path);
             }
           }
-
-          watchers.insert(sub->watcher);
         }
       }
     }