This repository was archived by the owner on Apr 13, 2019. It is now read-only.
Copy source MTU when cloning ETH transport link #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moved some other code that I felt was more specific to cloning the link to the _newLink() function
|
Impacts links that are dynamically created by an ethernet listener; explicit links can be used as a workaround. This also requires augmentations to the tests so that this case is covered in the future, as well as checks to make sure that mtu specifications are larger than the required fragmentation header. |
GlennCScott
pushed a commit
that referenced
this pull request
May 27, 2016
…efix 4023 walendo athena unregister prefix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection is made to an ETH listener, a "clone" of the listener's data is made for the new transport link that represents the connection itself. In the original code, the MTU for the "source" of the clone (the listener) was not being copied to the cloned transport link.
As part of this change, I also felt that there were a few other lines that are part of the "cloning" process that were being done in
_demuxDeliverywhich seemed more suitable for the_newLinkfunction which is more about cloning. This change is not an essential part of the fix, so not a big deal if it doesn't get integrated.