Show QR code for Refinery deposits#308
Merged
Merged
Conversation
Contributor
Author
|
resolves #307 |
Contributor
Author
|
One note, I decided on the QR code being an address instead of a BIP21 URI that includes both the address and the amount as I wasn't sure how many wallets support that |
Contributor
yeah I think that's the correct decision for now |
…s into feat/deposit-qr-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a QR code to the Refinery payment view so the deposit address can be scanned instead of copied manually.
Also keeps the payment modal usable on shorter screens and gives the QR enough white space to scan reliably.
Tested locally at mobile and desktop sizes. Lint, TypeScript, and the production build pass.